Conversation
Code Coverage
Files |
| try (final Result result = executeReadRequestFromSpaceStorage(rdRequest)) { | ||
| if (result instanceof SuccessResult) { | ||
| feature = ResultHelper.readFeatureFromResult(result, XyzFeature.class); | ||
| feature = ResultHelper.readFeatureFromResponse(result, XyzFeature.class); |
There was a problem hiding this comment.
I think we should be using NakshaFeature.class everywhere instead right?
There was a problem hiding this comment.
Good catch but no worries ;) This change was done because of refactoring the method name - I haven't worked on this module (app-service) yet.
You are right - this will have to be changed to NakshaFeature.class but this is not in the scope of this PR
|
|
||
| object JvmBoxingUtil { | ||
| @JvmStatic | ||
| fun <T> box(raw: Any?, _clazz: Class<T>): T? = |
There was a problem hiding this comment.
Oh we already have this as JvmProxyUtil, let's keep one and delete the other
There was a problem hiding this comment.
Nevermind, you deleted the other one 👍
| return this; | ||
| } | ||
|
|
||
| public static class List extends JvmListProxy<Copyright> { |
There was a problem hiding this comment.
In Space we have field copyright for List<Copyright>. This is a type for that field.
In proxy world generics are tricky so what we do with boxing typees (maps, lists etc) is that we create a dedicated type for them - for example we have StringList which is basically List<String> that also follows Proxy pattern.
This is quite similar :) We also have NakshaFeatureList and so on.
| /** | ||
| * The copyright information object. | ||
| */ | ||
| public class Copyright extends NakshaFeature { |
There was a problem hiding this comment.
Do we have a JSON example of the copyright? I assume it won't have the "type": "Feature", so probably extending AnyObject is better
There was a problem hiding this comment.
Yup, I changed this in a commit subsequent to this comment - now it extends AnyObject :)
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Amaneusz
force-pushed
the
v3_CASL_657-hub-module-v3-migration
branch
from
d78ce33 to
f215161
Compare
Code Coverage
Files |
3 participants
No description provided.