Merged
Conversation
…-migration # Conflicts: # here-naksha-handler-activitylog/src/main/java/com/here/naksha/handler/activitylog/ActivityLogHandler.java # here-naksha-handler-activitylog/src/test/java/com/here/naksha/handler/activitylog/assertions/ActivityLogSuccessResultAssertions.java # here-naksha-lib-model/src/commonMain/kotlin/naksha/model/objects/NakshaProperties.kt # here-naksha-lib-model/src/commonMain/kotlin/naksha/model/request/Write.kt
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
This reverts commit e98e748.
Signed-off-by: phmai <phuc.mai@here.com>
…-migration # Conflicts: # build.gradle.kts
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Code Coverage
Files
|
settings.gradle.kts
Outdated
| gradlePluginPortal() | ||
| } | ||
| plugins { | ||
| kotlin("jvm") version "2.1.0" |
Contributor
There was a problem hiding this comment.
could you move it to builSrc/build.gradle.kts? in dependencies section we have configuration of other plugins' versions
cyberhead-pl
approved these changes
Jan 21, 2025
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Code Coverage
Files
|
Amaneusz
approved these changes
Jan 21, 2025
| import naksha.base.NullableProperty | ||
| import naksha.model.objects.NakshaProperties | ||
|
|
||
| class NakshaActivityLog : AnyObject() { |
There was a problem hiding this comment.
I like that you mixed in kotlin for making your life easier!
| .toArray(PQuery[]::new); | ||
| final ReadFeatures readFeatures = new ReadFeatures(properties.getSpaceId()); | ||
| readFeatures.setQueryHistory(true); | ||
| readFeatures.setVersions(Integer.MAX_VALUE); |
There was a problem hiding this comment.
This line needs clarification (I think we should ask Alex) - whether the
.withReturnAllVersions(true) from v2 is equal to .setQueryHistory(true).setVersions(Integere.MAX_VALUE).
It's a fair assumption but double-checking wouldn't harm
Collaborator
Author
There was a problem hiding this comment.
confirmed with Alex through chat
Code Coverage
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.