Change to operators that will hit GIN index on Naksha feature tags#577
Merged
Change to operators that will hit GIN index on Naksha feature tags#577
Conversation
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Signed-off-by: phmai <phuc.mai@here.com>
Code Coverage
|
xeus2001
approved these changes
May 6, 2026
Member
xeus2001
left a comment
xeus2001
left a comment
There was a problem hiding this comment.
Okay with merging, just wonder about the need for the NULL handling.
|
|
||
| private fun containsOnlyTagExists(container: ListProxy<ITagQuery>): Boolean = | ||
| container.all { it is TagExists } | ||
| container.all { it == null || it is TagExists } |
Member
There was a problem hiding this comment.
Why is this change needed? The name of the function let me assume, that null should not be a valid TagExists
Collaborator
Author
There was a problem hiding this comment.
I initially assumed so as well, but apparently ListProxy<E : Any> : MutableList<E?>, the underlying E? means it can actually store null underneath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.