Skip to content

feat(scan): split scan spinner into report-creation and page-compiling stages#604

Merged
v3nant merged 1 commit into
mainfrom
feat/scan-progress-indication
Jul 10, 2026
Merged

feat(scan): split scan spinner into report-creation and page-compiling stages#604
v3nant merged 1 commit into
mainfrom
feat/scan-progress-indication

Conversation

@v3nant

@v3nant v3nant commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Splits the single "Scanning for EOL packages" spinner into two stages: report creation (ora spinner) and page compiling (cli-progress bar).
  • On report creation success, the spinner now shows "Created Scan Report {reportId}"; on failure, "Failed to Create Scan Report".
  • Page fetching now shows a "Compiling Report Results" progress bar tracking completed/total pages, updated as each page resolves.
  • Fixes a latent concurrency bug: page query promises were constructed (and thus started) eagerly for the whole report at once, so concurrentPageRequests never actually bounded in-flight requests. Queries are now built per-batch and progress is reported per-page as each settles.

Test plan

  • npm run typecheck
  • npx vitest run (247 passing)
  • biome check on changed files
  • Manual: run hd scan eol against an SBOM and confirm the two-stage spinner/progress bar behavior

@v3nant
v3nant marked this pull request as ready for review July 9, 2026 17:59
@v3nant
v3nant requested a review from a team as a code owner July 9, 2026 17:59
@v3nant
v3nant merged commit c77efee into main Jul 10, 2026
12 checks passed
@v3nant
v3nant deleted the feat/scan-progress-indication branch July 10, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants