chore(cli): update help text and tests to reference heroku-24 - #3042
Merged
Conversation
joshwlewis
temporarily deployed
to
AcceptanceTests
October 17, 2024 19:27 — with
GitHub Actions
Inactive
joshwlewis
temporarily deployed
to
AcceptanceTests
October 17, 2024 19:27 — with
GitHub Actions
Inactive
joshwlewis
force-pushed
the
jwl/heroku-24-default
branch
from
October 17, 2024 19:47
930ef7a to
31ff196
Compare
joshwlewis
temporarily deployed
to
AcceptanceTests
October 17, 2024 19:47 — with
GitHub Actions
Inactive
joshwlewis
temporarily deployed
to
AcceptanceTests
October 17, 2024 19:47 — with
GitHub Actions
Inactive
joshwlewis
marked this pull request as ready for review
October 17, 2024 20:17
k80bowman
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the last steps in the heroku-24 rollout plan is to set
heroku-24as the default stack for new apps. That change (https://github.com/heroku/api/pull/15582) will ship on October 23rd.This PR updates a few areas of the CLI to match the new default. I don't think it's super important to ship this change exactly on October 23rd. A few days before or after is probably fine.