fix(cli): Fixes bug with command 'ps -x' (sudo) - #3051
Merged
Conversation
eablack
requested changes
Oct 22, 2024
eablack
left a comment
Contributor
There was a problem hiding this comment.
Hmm, I'm still seeing an error when i try to run this with your branch:
is it possible we need to add another optional chain here? https://github.com/heroku/cli/pull/3051/files#diff-5d43d9c03ed768f9c4f93c44502238c8961bba579421ce39c334cbdfe20b1f0eR65
Contributor
Author
No, the problem is Run tests with: It will require a few times for your 2FA method, but ultimately it will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The command
fails currently for Private Space apps because the extended property on the JSON response has many of its properties set to
null, giving a TypeError when trying to coerce the nullportnumber to a string.Here we correct the type definition, allowing for null values on all of the extended properties and handling that case appropriately when building the output table display.
SOC2 Compliance
Slack thread for reference
GUS Work Item