Updated analytics to be passive yet guaranteed to complete before exit - #3085
Merged
Conversation
justinwilaby
force-pushed
the
jw/2x-speedup
branch
from
November 12, 2024 01:25
6de008c to
f62cc49
Compare
justinwilaby
temporarily deployed
to
AcceptanceTests
November 12, 2024 01:25 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
justinwilaby
temporarily deployed
to
AcceptanceTests
November 12, 2024 01:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
zwhitfield3
approved these changes
Jan 15, 2025
zwhitfield3
left a comment
zwhitfield3
left a comment
Contributor
There was a problem hiding this comment.
After reviewing this refactor, the changes make sense. However, these changes only affect Herokulytics performance and in no way affect our performance analytics regarding data collection or performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR boosts execution performance by 2x.
Before: Analytics was run sequential to command execution.
After: Analytics runs parallel to command execution but is awaited if the command finishes first.
This give approx 100% increase in performance.