Skip to content

chore(W-17237970): Improve buildpacks:index for fir apps - #3227

Merged
justinwilaby merged 8 commits into
mainfrom
jw/W-17237970
Feb 19, 2025
Merged

chore(W-17237970): Improve buildpacks:index for fir apps#3227
justinwilaby merged 8 commits into
mainfrom
jw/W-17237970

Conversation

@justinwilaby

@justinwilaby justinwilaby commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

This PR updates the buildpacks command to distinguish between classic and fir buildpacks

Testing

  1. run buildpacks --help Note the updated help text
  2. run buildpacks -a <APP_NAME> where APP_NAME is a Fir app and again for a cedar app.
  3. Observe the new styled headers

@justinwilaby
justinwilaby requested a review from a team as a code owner February 19, 2025 20:02
@justinwilaby justinwilaby changed the title chore(W-17857872): update help text for logs command (#3225) chore(W-17237970): Improve buildpacks:index for fir apps Feb 19, 2025
SandyPantsLai
SandyPantsLai reviewed Feb 19, 2025
View reviewed changes
Comment thread packages/cli/src/commands/buildpacks/index.ts Outdated
SandyPantsLai
SandyPantsLai reviewed Feb 19, 2025
View reviewed changes
Comment thread packages/cli/src/commands/buildpacks/index.ts Outdated
SandyPantsLai
SandyPantsLai reviewed Feb 19, 2025
View reviewed changes
Comment thread packages/cli/src/commands/buildpacks/index.ts Outdated
@justinwilaby @SandyPantsLai
Update packages/cli/src/commands/buildpacks/index.ts
3dc5c4d 
Co-authored-by: Sandy Lai <sandy.lai@salesforce.com>
@justinwilaby @SandyPantsLai
Update packages/cli/src/commands/buildpacks/index.ts
c0e0cbf 
Co-authored-by: Sandy Lai <sandy.lai@salesforce.com>
@justinwilaby @SandyPantsLai
Update packages/cli/src/commands/buildpacks/index.ts
5cdc3a6 
Co-authored-by: Sandy Lai <sandy.lai@salesforce.com>
SandyPantsLai
SandyPantsLai reviewed Feb 19, 2025
View reviewed changes
Comment thread packages/cli/src/commands/buildpacks/index.ts Outdated
@justinwilaby @SandyPantsLai
Update packages/cli/src/commands/buildpacks/index.ts
97e481b 
Co-authored-by: Sandy Lai <sandy.lai@salesforce.com>
eablack
eablack approved these changes Feb 19, 2025
View reviewed changes

@eablack eablack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks/works great! :shipit:

@justinwilaby
justinwilaby merged commit 0f8f250 into main Feb 19, 2025
@justinwilaby
justinwilaby deleted the jw/W-17237970 branch February 19, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eablack eablack eablack approved these changes
+1 more reviewer
@SandyPantsLai SandyPantsLai SandyPantsLai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinwilaby @eablack @SandyPantsLai