Skip to content

fix: pg:backups:download respects HTTPS_PROXY env var #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heroku-johnny merged 4 commits into from
Jul 28, 2026
Merged

fix: pg:backups:download respects HTTPS_PROXY env var #3836

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd11de3
fix: pg:backups:download respects HTTPS_PROXY env var
heroku-johnny Jul 27, 2026
fc27307
fix: sort imports to satisfy perfectionist/sort-imports linter
heroku-johnny Jul 27, 2026
85237e3
Merge branch 'main' into W-23597944
heroku-johnny Jul 27, 2026
6390dcd
Merge branch 'main' into W-23597944
heroku-johnny Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/pg/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import cliProgress from 'cli-progress'
import fs from 'fs-extra'
import {HttpsProxyAgent} from 'https-proxy-agent'
import https from 'node:https'
import Path from 'node:path'

Expand Down Expand Up @@ -30,7 +31,9 @@ export default function download(url: string, path: string, opts: downloadOption
return new Promise((resolve, reject) => {
fs.mkdirSync(Path.dirname(path), {recursive: true})
const file = fs.createWriteStream(path)
https.get(url, (rsp: any) => {
const proxy = process.env.https_proxy || process.env.HTTPS_PROXY
const options: https.RequestOptions = proxy ? {agent: new HttpsProxyAgent(proxy)} : {}
https.get(url, options, (rsp: any) => {
if (tty && opts.progress) showProgress(rsp)
rsp.pipe(file)
.on('error', reject)
Expand Down
Loading