feat: add http-timeout option - #1445
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 72.80% 72.86% +0.06%
==========================================
Files 300 300
Lines 11104 11124 +20
==========================================
+ Hits 8084 8106 +22
+ Misses 2120 2119 -1
+ Partials 900 899 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
reviewed
Jul 2, 2026
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
jooola
reviewed
Jul 2, 2026
jooola
approved these changes
Jul 2, 2026
phm07
pushed a commit
that referenced
this pull request
Jul 24, 2026
<!-- section-start changelog --> ### Removed deprecated Datacenter from Server and Primary IP Removed the deprecated Datacenter property from the Server and Primary IP resources. Since the property was already removed from the Hetzner Cloud API, we do not consider this a breaking change (see [changelog entry](https://docs.hetzner.cloud/changelog#2026-07-01-removing-datacenters)). The `hcloud primary-ip create --datacenter` and `hcloud server create --datacenter` flags have been removed in favor of `--location`. Additionally, `hcloud primary-ip describe` and `hcloud server describe` will no longer show the Datacenter property. In place of the `--datacenter` flag the `--location` flag can be used. The Location name is the first part of the Datacenter name, e.g. the part before `-`. Example: **Before:** ```sh $ hcloud server create --datacenter fsn1-dc14 $ hcloud primary-ip create --datacenter hel1-dc2 ``` **After:** ```sh $ hcloud server create --location fsn1 $ hcloud primary-ip create --location hel1 ``` ### Features - add http-timeout option (#1445) - remove datacenter property from server and primary_ip (#1460) ### Bug Fixes - **primary-ip**: format IPv6 properly in describe (#1451) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ### Removed deprecated Datacenter from Server and Primary IP Removed the deprecated Datacenter property from the Server and Primary IP resources. Since the property was already removed from the Hetzner Cloud API, we do not consider this a breaking change (see [changelog entry](https://docs.hetzner.cloud/changelog#2026-07-01-removing-datacenters)). The `hcloud primary-ip create --datacenter` and `hcloud server create --datacenter` flags have been removed in favor of `--location`. Additionally, `hcloud primary-ip describe` and `hcloud server describe` will no longer show the Datacenter property. In place of the `--datacenter` flag the `--location` flag can be used. The Location name is the first part of the Datacenter name, e.g. the part before `-`. Example: **Before:** ```sh $ hcloud server create --datacenter fsn1-dc14 $ hcloud primary-ip create --datacenter hel1-dc2 ``` **After:** ```sh $ hcloud server create --location fsn1 $ hcloud primary-ip create --location hel1 ``` ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable
http-timeoutoption.Since the default Go HTTP client has a timeout of 0, this is the proposed default for the new option as well to keep behavior consistent. A value of 0 means no timeout.