docs: improve binary download command for linux setup#1068
Merged
Conversation
Member
jooola
commented
Jun 2, 2025
jooola
commented
- Make archive download silent
- Do not extract docs or LICENSE
- Do not preserve the owner of the file in the archive
- Do not extract docs or LICENSE - Do not preserve the owner of the file in the archive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 70.34% 70.34%
=======================================
Files 247 247
Lines 10873 10873
=======================================
Hits 7649 7649
Misses 2547 2547
Partials 677 677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
commented
Jun 2, 2025
| curl -LO https://github.com/hetznercloud/cli/releases/download/v1.51.0/hcloud-linux-amd64.tar.gz | ||
| sudo tar -C /usr/local/bin -xzf hcloud-linux-amd64.tar.gz | ||
| curl -sSLO https://github.com/hetznercloud/cli/releases/download/v1.51.0/hcloud-linux-amd64.tar.gz | ||
| sudo tar -C /usr/local/bin --no-same-owner -xzf hcloud-linux-amd64.tar.gz hcloud |
Member
Author
There was a problem hiding this comment.
We could also try to fix this on the goreleaser side using builds_info: https://goreleaser.com/customization/archive/
Member
There was a problem hiding this comment.
Not sure which user & group ID we should choose there, as that highly depends on the users local setup.
apricote
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.