Skip to content

feat(datacenter, server-type): move available and recommended to server_type#1384

Merged
phm07 merged 1 commit intomainfrom
server-type-available-recommended
Apr 23, 2026
Merged

feat(datacenter, server-type): move available and recommended to server_type#1384
phm07 merged 1 commit intomainfrom
server-type-available-recommended

Conversation

@phm07
Copy link
Copy Markdown
Contributor

@phm07 phm07 commented Apr 10, 2026

@phm07 phm07 self-assigned this Apr 10, 2026
@phm07 phm07 requested a review from a team as a code owner April 10, 2026 08:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.91%. Comparing base (58e80f9) to head (f5279f4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/datacenter/describe.go 75.00% 1 Missing ⚠️
internal/cmd/servertype/list.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   66.89%   66.91%   +0.02%     
==========================================
  Files         300      300              
  Lines       13487    13506      +19     
==========================================
+ Hits         9022     9038      +16     
- Misses       3567     3570       +3     
  Partials      898      898              
Flag Coverage Δ
e2e 49.35% <3.84%> (-0.05%) ⬇️
unit 67.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@lukasmetzner lukasmetzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions on the coding style. I found the code to be hard to read, otherwise.

Other than that, this looks good once we bump hcloud-go and rebase this.

Comment thread internal/cmd/servertype/list.go Outdated
Comment thread internal/cmd/servertype/list.go Outdated
Comment thread internal/cmd/datacenter/describe.go Outdated
@phm07 phm07 force-pushed the server-type-available-recommended branch from 729515a to 7f71e36 Compare April 23, 2026 12:10
@phm07 phm07 force-pushed the server-type-available-recommended branch from 7f71e36 to f5279f4 Compare April 23, 2026 12:36
@phm07 phm07 merged commit a7c00ba into main Apr 23, 2026
7 checks passed
@phm07 phm07 deleted the server-type-available-recommended branch April 23, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants