Skip to content

revert: fix: ignore firewall rule description when looking for a rule to delete#966

Merged
jooola merged 1 commit intomainfrom
revert-4535f26bad3436248585cea4fbec90a5262a20f6
Jan 23, 2025
Merged

revert: fix: ignore firewall rule description when looking for a rule to delete#966
jooola merged 1 commit intomainfrom
revert-4535f26bad3436248585cea4fbec90a5262a20f6

Conversation

@jooola
Copy link
Copy Markdown
Member

@jooola jooola commented Jan 22, 2025

This reverts commit 4535f26 (#961)

Two firewall rules with only a different description does not raise any validation error in the backend. Therefor, we must be able to target duplicate rules with different descriptions. Users must provide the description to be able to delete a rule.

@jooola jooola requested a review from a team as a code owner January 22, 2025 16:12
@jooola jooola requested a review from phm07 January 22, 2025 16:13
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (3bd76c4) to head (d1088a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   70.02%   70.01%   -0.02%     
==========================================
  Files         245      245              
  Lines       10720    10715       -5     
==========================================
- Hits         7507     7502       -5     
  Misses       2537     2537              
  Partials      676      676              
Flag Coverage Δ
e2e 46.78% <100.00%> (-0.03%) ⬇️
unit 63.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 48b4fc7 into main Jan 23, 2025
@jooola jooola deleted the revert-4535f26bad3436248585cea4fbec90a5262a20f6 branch January 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants