Skip to content

Fix manager clippy debt#12

Closed
hev wants to merge 1 commit into
mainfrom
fix/clippy-debt-manager
Closed

Fix manager clippy debt#12
hev wants to merge 1 commit into
mainfrom
fix/clippy-debt-manager

Conversation

@hev

@hev hev commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Closes #11.

Summary

  • Added a schema-summary type alias for the complex /import validator return type.
  • Rewrote the two reported row loops to enumerate over extracted ids.
  • Applied existing rustfmt debt and fixed the stale serialisation benchmark QueryResult initializer that --all-targets exposed.

Local evidence

$ cargo fmt --check
$ cargo clippy --workspace --all-targets -- -D warnings
    Checking hevsearch-core v0.1.0 (/Users/hev/workspace/lyr/search/crates/hevsearch-core)
    Checking hevsearch-api v0.1.0 (/Users/hev/workspace/lyr/search/crates/hevsearch-api)
    Checking hevsearch-bench v0.1.0 (/Users/hev/workspace/lyr/search/crates/hevsearch-bench)
    Checking hevsearch-python v0.1.0 (/Users/hev/workspace/lyr/search/python)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.15s

Once this merges, PR #10 should need only rebase + rerun.

@hev hev added the gate:impl Implementation PR awaiting CI + spec-review + merge (agentic-gates §2) label Jul 8, 2026
@hev

hev commented Jul 8, 2026

Copy link
Copy Markdown
Owner Author

Attributed the CI failure for local_fs_fuzzy_fts_matches_typo_query.

Command used on both revisions:

./scripts/cargo test -j 2 -p hevsearch-core --test manager_local_fs local_fs_fuzzy_fts_matches_typo_query -- --exact --nocapture

Results:

  • PR branch fix/clippy-debt-manager at 999b60a: test ran and failed with the same panic as CI:
thread 'local_fs_fuzzy_fts_matches_typo_query' panicked at crates/hevsearch-core/tests/manager_local_fs.rs:599:29:
index out of bounds: the len is 0 but the index is 0
test local_fs_fuzzy_fts_matches_typo_query ... FAILED
  • origin/main detached at 702bf4e: after ./scripts/cargo clean -p hevsearch-core to clear stale incremental artifacts from the checkout, the same command ran the test and failed identically:
thread 'local_fs_fuzzy_fts_matches_typo_query' panicked at crates/hevsearch-core/tests/manager_local_fs.rs:599:29:
index out of bounds: the len is 0 but the index is 0
test local_fs_fuzzy_fts_matches_typo_query ... FAILED

Attribution: this is pre-existing on origin/main, not introduced by the needless_range_loop rewrite in this PR. Per the requested constraint, I did not change code here; this should be tracked as a separate main defect.

@hev

hev commented Jul 8, 2026

Copy link
Copy Markdown
Owner Author

spec-review (conformance pass): ✅ approve, with one scope note — reviewed against issue #11.

Merge after #14. (Posted by the dispatch loop as the manual spec-review equivalent.)

@hevbot

hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #15, which stacks this clippy fix with the fuzzy typo test fix from #14 and the main-branch formatter verification so CI can go green in one PR. Leaving this open for hev to decide on merge/closure.

@hevbot

hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #15 (merged): its clippy fixes were cherry-picked into the stacked branch with authorship preserved, and main's fmt / clippy / test lane is now green. Closing — issue #11 closed with #15.

@hevbot hevbot closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate:impl Implementation PR awaiting CI + spec-review + merge (agentic-gates §2)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main fails its own CI: clippy -D warnings violations in manager.rs (blocks PR #10 / issue #7)

2 participants