Skip to content

feat(pr): support Codeberg pull requests#67

Closed
hewigovens wants to merge 1 commit into
mainfrom
spr/hewigovens/featpr-support-codeberg-pull-requests
Closed

feat(pr): support Codeberg pull requests#67
hewigovens wants to merge 1 commit into
mainfrom
spr/hewigovens/featpr-support-codeberg-pull-requests

Conversation

@hewigovens

Copy link
Copy Markdown
Owner
  • add GitHub/Codeberg hosted repo parsing and dynamic PR labels
  • document jj-spr GitHub flow and Codeberg bookmark flow
  • fix Finder reveal and file-list header layout regressions

@hewigovens hewigovens marked this pull request as ready for review June 5, 2026 12:15
@hewigovens hewigovens marked this pull request as draft June 5, 2026 12:15
hewigovens added a commit that referenced this pull request Jun 5, 2026
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- document jj-spr GitHub flow and Codeberg bookmark flow
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from 5ef82ff to fefc8fd Compare June 5, 2026 12:22
hewigovens added a commit that referenced this pull request Jun 5, 2026
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- document jj-spr GitHub flow and Codeberg bookmark flow
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from fefc8fd to 08a32ec Compare June 5, 2026 12:23
@hewigovens hewigovens marked this pull request as ready for review June 5, 2026 12:28
hewigovens added a commit that referenced this pull request Jun 5, 2026
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- document jj-spr GitHub flow and Codeberg bookmark flow
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from 08a32ec to 019cd97 Compare June 5, 2026 12:34
@hewigovens hewigovens marked this pull request as draft June 5, 2026 12:34
hewigovens added a commit that referenced this pull request Jun 5, 2026
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- document bookmark-based GitHub and Codeberg PR flow
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from 019cd97 to 1c811fc Compare June 5, 2026 12:34
@hewigovens hewigovens marked this pull request as ready for review June 5, 2026 21:49
hewigovens added a commit that referenced this pull request Jun 5, 2026
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- document bookmark-based GitHub and Codeberg PR flow
- add Repo-level coverage for Codeberg PR compose URLs
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from 1c811fc to 9e9acb5 Compare June 5, 2026 22:01
@hewigovens hewigovens marked this pull request as draft June 5, 2026 22:01
- add GitHub/Codeberg hosted repo parsing and dynamic PR labels
- show public Codeberg PR status through the Forgejo API
- document bookmark-based GitHub and Codeberg PR flow
- add Repo-level coverage for Codeberg PR compose/status URLs
- fix Finder reveal and file-list header layout regressions

Pull Request: #67
@hewigovens hewigovens force-pushed the spr/hewigovens/featpr-support-codeberg-pull-requests branch from 9e9acb5 to 68621ba Compare June 5, 2026 23:39
@hewigovens hewigovens marked this pull request as ready for review June 6, 2026 06:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68621ba81c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +60 to +67
let url = format!(
"{}/repos/{}/{}/pulls?state=all&base={}&head={}",
CODEBERG_API_URL,
encode_url_component(remote.owner()),
encode_url_component(remote.repo()),
encode_url_component(&base),
encode_url_component(bookmark)
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Query Codeberg PRs with supported filters

For Codeberg/Gitea, the list-pulls endpoint does not support base or head query parameters (the base filter is base_branch, and exact base/head lookup is a separate /pulls/{base}/{head} route). In repositories with more than one page of PRs, this call returns only the first page of all PRs, so an existing PR for the selected bookmark can be missed and JayJay will show no PR status or open the compose URL instead of the existing PR.

Useful? React with 👍 / 👎.

@hewigovens

Copy link
Copy Markdown
Owner Author

Superseded by #69 (rebased on main, dropped the bundled UI fix into its own change, and replaced the curl shell-out with the jayjay-network crate).

@hewigovens hewigovens closed this Jun 6, 2026
@hewigovens hewigovens deleted the spr/hewigovens/featpr-support-codeberg-pull-requests branch June 7, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant