Changed 'email-domain' from key to filter - #101
Closed
seanrose wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Hi - can you write some specs for this change and we will be happy to merge |
Author
|
Thanks! I'll work on adding them this weekend. |
Author
|
I updated api_spec.rb to account and test for the change properly. |
hexgnu
pushed a commit
that referenced
this pull request
Jun 4, 2013
Owner
|
Got it taken care of. Also the test was failing. Be sure to check it next time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Email domain filtering for companies is currently broken in the Ruby gem.
According to the LinkedIn API doc, 'email-domain' functions as a filter, not a key, for the companies resource. It's entered as this format: companies? instead of companies/ as it currently is in the Ruby gem.
https://developer.linkedin.com/documents/company-lookup-api-and-fields