Fix: add text chunking for non-English language pipeline - #105
Merged
Conversation
Dustin4444
approved these changes
Feb 19, 2025
Dustin4444
approved these changes
Feb 20, 2025
python273
added a commit
to python273/kokoro
that referenced
this pull request
Feb 23, 2025
hexgrad
pushed a commit
that referenced
this pull request
Feb 23, 2025
* Add Result.text_index to be able to map segments to paragraphs * Fix speed re: #105
Kevklatman
referenced
this pull request
in Kevklatman/kokoro
Jun 6, 2025
Co-authored-by: Your Name <your.email@example.com>
Kevklatman
referenced
this pull request
in Kevklatman/kokoro
Jun 6, 2025
* Add Result.text_index to be able to map segments to paragraphs * Fix speed re: #105
semidark
added a commit
to semidark/kokoro
that referenced
this pull request
Apr 17, 2026
The warning 'Chunking logic not yet implemented' in __init__ was added in Jan 2025, but sentence-level chunking was implemented in hexgrad#105 (Feb 2025). The warning is now misleading for all espeak-ng languages. Also add commented-out German voice stubs (df_anna, dm_daniel) to kokoro.js/src/voices.js, pending trained voice weights.
semidark
added a commit
to semidark/kokoro
that referenced
this pull request
Apr 17, 2026
The warning 'Chunking logic not yet implemented' was added in Jan 2025 but sentence-level chunking was implemented in hexgrad#105 (Feb 2025). The warning is now misleading for all espeak-ng languages.
geneing
pushed a commit
to geneing/hexgrad-kokoro
that referenced
this pull request
Apr 21, 2026
…ad#111) * Add Result.text_index to be able to map segments to paragraphs * Fix speed re: hexgrad#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the generator to loop on segments to process long-form audio didn't work for non English languages, actually the audio was generated for just the first max 500 chars.
This commit fixes it with a kind of trivial chunking method butm for Italian, for example, it does the job.