Skip to content

chore(deps): remove acorn#211

Merged
SukkaW merged 1 commit intohexojs:masterfrom
SukkaW:remove-acorn
Jun 14, 2020
Merged

chore(deps): remove acorn#211
SukkaW merged 1 commit intohexojs:masterfrom
SukkaW:remove-acorn

Conversation

@SukkaW
Copy link
Member

@SukkaW SukkaW commented Jun 12, 2020

acorn is introduced in #50. However, I don't see why the acorn is required.

Seeing the related issue, still don't know why acorn should be included in dependencies.

The PR shouldn't be merged before @tomap gives the explanation, in case the PR breaks something.

@SukkaW SukkaW requested review from a team and tomap June 12, 2020 11:50
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.062% when pulling 58032bc on SukkaW:remove-acorn into af92881 on hexojs:master.

@tomap
Copy link
Contributor

tomap commented Jun 14, 2020

Hi, I'm not sure why I I introduced it. Two possible reasons:
Npm was asking for it (peerdependency) or
There was a security issue with a secondary dependency, and including it directly fixed the issue
In any case, you can remove it if you tested the removal without issue!

@SukkaW
Copy link
Member Author

SukkaW commented Jun 14, 2020

@tomap I have runned npm ls acorn. It appears that acorn is a dependency of eslint & rewire.

Since it is a dependency of two devDependencies, I think we could remove it without breaking normal users (Yes, maybe developers like us might be affected, but is doesn't matter much, right?).

@SukkaW SukkaW merged commit b43f94a into hexojs:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants