Bugfix/routing#43
Merged
Merged
Conversation
…s populated for '/' (v3.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a router initialization bug where the initial route never resolved its match on load. The router seeds
currentRoutewith an uninitialized placeholder (matched: []) and then navigates to the current location on init. For the root path/— and any path whosepath/params/query/hashcoincided with that placeholder —isSameRoutetreated the first navigation as a duplicate and discarded the real match, soroute().matchedstayed empty forever andOutlet(which renders a nested child only whenmatched.length >= 2) rendered nothing at/.Changes:
isSameRoutenow treats a placeholder that resolved to no match as never equal to a target that resolved to a real match, so the first navigation commits.tests/router.init-match.test.ts) assertingroute().matchedis populated for/after init.Outletdocumentation in AGENTS.md §9 (top-levelRoute()vs nestedOutlet()).Bumped
sibujsto3.4.1(SemVer patch) and updated its CHANGELOG.Related Issue
Closes #
Type of Change
Checklist