Remove private docs HTTP serving#140
Merged
Merged
Conversation
Private docs are now served by the docs-private Fastly compute service, which authenticates against hexpm directly and reads the private bucket itself. Remove the entire HTTP layer: the Plug router, OAuth client, error page templates, static assets, Bandit server, and the serving-only store/HTTP/auth functions and configuration. The app is now a pure background pipeline (SQS consumer, docs processing, uploads, search indexing, and CDN purges, which still include the private Fastly service).
ericmj
added a commit
that referenced
this pull request
Jul 9, 2026
PR #139 added test/hexdocs/store/gs_test.exs, which uses Bandit and Plug.Conn for a mock GCS server, while PR #140 removed the bandit dependency along with the HTTP serving layer. Each PR passed CI against its own base, but together they broke compilation of the test suite on main. Keep the app itself a pure background pipeline by re-adding bandit only for the test environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private docs are now served by the docs-private Fastly compute service (hexpm-ops#178, hexpm-ops#182), which authenticates against hexpm directly and reads the private bucket itself, so the app no longer needs an HTTP server.
This removes the entire HTTP layer: the Plug router, OAuth PKCE client, error page templates, static assets, the Bandit server and the
bandit/logsterdependencies (dropping transitiveplug), the/statusendpoint, and the serving-only store/HTTP/auth functions and configuration (port, scheme, OAuth client, session salts). The app is now a pure background pipeline: SQS consumer, docs processing, uploads, search indexing, and CDN purges — still including the private Fastly service purge from #137.Deploying this image requires the readiness probe removal in the hexpm-ops PR to land first, since the probe hits
GET /status:4002.