ci: add tag-triggered npm publish workflow with OIDC provenance#11
Merged
jrusso1020 merged 1 commit into03-23-ci_add_ci_pipeline_with_build_typecheck_and_test_jobsfrom Mar 23, 2026
Conversation
miguel-heygen
approved these changes
Mar 23, 2026
jrusso1020
force-pushed
the
03-23-ci_add_tag-triggered_npm_publish_workflow_with_oidc_provenance
branch
from
7e215c0 to
77a4c4e
Compare
jrusso1020
commented
Mar 23, 2026
Comment on lines
+22
to
+27
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm build | ||
| - run: pnpm -r typecheck | ||
| - run: pnpm --filter @hyperframes/core test | ||
| - run: pnpm --filter @hyperframes/engine test | ||
| - run: pnpm --filter @hyperframes/core test:hyperframe-runtime-ci |
Collaborator
Author
There was a problem hiding this comment.
we are rerunning these? should we just have it depend on the other jobs that already do this?
Collaborator
Author
There was a problem hiding this comment.
Good call — removed the validate job entirely. The tag should only be pushed after CI is green on main, so re-running is redundant. The publish job now just builds and publishes.
jrusso1020
force-pushed
the
03-23-ci_add_tag-triggered_npm_publish_workflow_with_oidc_provenance
branch
from
77a4c4e to
5a74209
Compare
jrusso1020
merged commit 5a0b4ea
into
03-23-ci_add_ci_pipeline_with_build_typecheck_and_test_jobs
7 checks passed
2 tasks
5 tasks
vanceingalls
added a commit
that referenced
this pull request
Apr 16, 2026
Blockers: - #2: late_init_set false positive on fractional opacity (0.5 matched as 0) Fixed: /opacity\s*:\s*0(?![.\d])/ negative lookahead - #3: scene-1 prefix skip matches scene 10+ (s1- matches s10-) Fixed: extract full number and compare exactly High severity: - #4: autoAlpha not covered by late_init_set Fixed: checks both opacity and autoAlpha - #5: al() crashes on non-hex colors (#fff shorthand, rgb(), null) Fixed: guard + shorthand expansion + NaN fallback - #6: "Full palette" with null bg crashes isDark Fixed: null guard defaults to dark - #7: template literals missed by tl_from_in_multiscene Fixed: regex includes backtick quotes Medium: - #9: no retry limit on eval failures → infinite loop Fixed: max 2 retries, then escalate to user - #10: vague ID convention Fixed: explicit s{N}- prefix rule in multi-scene.md - #11: visual-style.md backward compat Fixed: Step 0b checks both filenames - #13: preview_html script injection Fixed: documented prohibition in design-picker.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add npm publish workflow triggered by
v*git tags, plus aset-versionscript and release docs.Why
Items 3 from VA-855. Enables releasing
@hyperframes/*packages to npm from CI with a simple workflow.How
Publish workflow (
.github/workflows/publish.yml)Two jobs:
Key design decisions:
NPM_TOKENsecret needed--provenance— cryptographically links packages to the exact GitHub commit--no-git-checks— required for detached HEAD in CInpm-publishGitHub environment — can require manual approvalVersion script (
scripts/set-version.ts)All packages use fixed versioning (same version number, like Remotion/Next.js).
Updated CONTRIBUTING.md
Prerequisites
npm-publishenvironment created in GitHub repo settingsTest plan
pnpm set-versiontested (usage help + version bump)v0.1.1tag after merging the full stackStack: depends on #10