fix: resolve build and typecheck failures across packages#9
Merged
jrusso1020 merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
3 tasks
miguel-heygen
approved these changes
Mar 23, 2026
vanceingalls
added a commit
that referenced
this pull request
Apr 16, 2026
Blockers: - #2: late_init_set false positive on fractional opacity (0.5 matched as 0) Fixed: /opacity\s*:\s*0(?![.\d])/ negative lookahead - #3: scene-1 prefix skip matches scene 10+ (s1- matches s10-) Fixed: extract full number and compare exactly High severity: - #4: autoAlpha not covered by late_init_set Fixed: checks both opacity and autoAlpha - #5: al() crashes on non-hex colors (#fff shorthand, rgb(), null) Fixed: guard + shorthand expansion + NaN fallback - #6: "Full palette" with null bg crashes isDark Fixed: null guard defaults to dark - #7: template literals missed by tl_from_in_multiscene Fixed: regex includes backtick quotes Medium: - #9: no retry limit on eval failures → infinite loop Fixed: max 2 retries, then escalate to user - #10: vague ID convention Fixed: explicit s{N}- prefix rule in multi-scene.md - #11: visual-style.md backward compat Fixed: Step 0b checks both filenames - #13: preview_html script injection Fixed: documented prohibition in design-picker.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix pre-existing build and typecheck failures that prevent
pnpm buildandpnpm -r typecheckfrom succeeding.Why
CI pipeline (next PR in stack) needs clean build + typecheck. These issues block that.
How
*.test.tsfrom tsconfigexclude(tsc was failing on vitest imports)vitestdevDependency andtestscript.d.tsdeclarations viatsc --emitDeclarationOnlyafter esbuild bundle (CLI couldn't resolve producer types)renderComposition()calls withcreateRenderJob()+executeRenderJob()(API was renamed during migration)Test plan
pnpm buildpassespnpm -r typecheckpassespnpm --filter @hyperframes/core test— 330 tests passpnpm --filter @hyperframes/engine test— 18 tests passpnpm --filter @hyperframes/core test:hyperframe-runtime-ci— all contract tests pass