fix(core): separate info count from warning count in linter results#126
Closed
Conversation
29959e8 to
f0955b7
Compare
c0b4c5e to
3995974
Compare
This was referenced Mar 29, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
The linter was computing warningCount as findings.length - errorCount, which lumped info-severity findings into the warning count. Now counts warnings and infos separately, and adds a new infoCount field. Reproducer: # Create composition with timed element missing class="clip" npx hyperframes lint # Was: "0 errors, 1 warning(s)" npx hyperframes lint --json # Was: severity: "info" but warningCount: 1 # Now warningCount: 0, infoCount: 1
3995974 to
d649ad3
Compare
f0955b7 to
919e4c2
Compare
This was referenced Mar 29, 2026
Closed
Collaborator
Author
|
Consolidated into fix/lint-improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Stack
Summary
warningCountasfindings.length - errorCount, which lumped info-severity findings into the warning countinfoCountfield toHyperframeLintResultReproducer
Stack
5/8 — Depends on #125
🤖 Generated with Claude Code