Skip to content

fix(core): separate info count from warning count in linter results#126

Closed
miguel-heygen wants to merge 1 commit into03-29-fix_cli_respect_--json_flag_on_lint_error_pathsfrom
03-29-fix_core_separate_info_count_from_warning_count_in_linter_results
Closed

fix(core): separate info count from warning count in linter results#126
miguel-heygen wants to merge 1 commit into03-29-fix_cli_respect_--json_flag_on_lint_error_pathsfrom
03-29-fix_core_separate_info_count_from_warning_count_in_linter_results

Conversation

@miguel-heygen
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen commented Mar 29, 2026

PR Stack

# PR Status
1 #122 — fix: info width/height swap ← base
2 #123 — fix: include all 9 templates in build
3 #124 — fix: suppress ANSI in non-TTY
4 #125 — fix: lint --json error paths
5 #126 — fix: separate info/warning counts
6 #127 — fix: lint severity display
7 #128 — fix: render output path error
8 #129 — fix: zero-duration error message ← top

Summary

  • The linter computed warningCount as findings.length - errorCount, which lumped info-severity findings into the warning count
  • Now counts warnings and infos separately with explicit filters
  • Adds a new infoCount field to HyperframeLintResult

Reproducer

# Create composition with timed element missing class="clip"
npx hyperframes lint --json | jq '{warningCount, infoCount}'
# Was: {"warningCount": 1}  (but severity was "info")
# Now: {"warningCount": 0, "infoCount": 1}

Stack

5/8 — Depends on #125

🤖 Generated with Claude Code

The linter was computing warningCount as findings.length - errorCount,
which lumped info-severity findings into the warning count. Now counts
warnings and infos separately, and adds a new infoCount field.

Reproducer:
  # Create composition with timed element missing class="clip"
  npx hyperframes lint        # Was: "0 errors, 1 warning(s)"
  npx hyperframes lint --json # Was: severity: "info" but warningCount: 1
  # Now warningCount: 0, infoCount: 1
@miguel-heygen miguel-heygen force-pushed the 03-29-fix_core_separate_info_count_from_warning_count_in_linter_results branch from 3995974 to d649ad3 Compare March 29, 2026 11:51
@miguel-heygen miguel-heygen force-pushed the 03-29-fix_cli_respect_--json_flag_on_lint_error_paths branch from f0955b7 to 919e4c2 Compare March 29, 2026 11:51
@miguel-heygen
Copy link
Copy Markdown
Collaborator Author

Consolidated into fix/lint-improvements.

@miguel-heygen miguel-heygen deleted the 03-29-fix_core_separate_info_count_from_warning_count_in_linter_results branch April 6, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant