fix(cli): distinguish info vs warning severity in lint output#127
Conversation
af31d4f to
d4af810
Compare
c0b4c5e to
3995974
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
miguel-heygen
left a comment
There was a problem hiding this comment.
Two issues:
1. Missing pluralization for info count in check-hyperframe-static.ts
formatCounts outputs "3 info" instead of "3 infos". Warnings get proper conditional pluralization (warning vs warnings), but info doesn't:
// Current
parts.push(`${result.infoCount} info`);
// Should be
parts.push(`${result.infoCount} info${result.infoCount === 1 ? "" : "s"}`);2. Verify findings loop in check-hyperframe-static.ts
The CLI lint command now has a three-way severity prefix (✗ / ⚠ / ℹ), but the findings output loop in check-hyperframe-static.ts is not in this diff. If it still uses a two-way check, info findings will render with the warning prefix there — the same problem this PR fixes in the CLI.
The lint command displayed info-level findings with the warning icon and counted them in the warning total, while JSON correctly reported severity as "info". Now info findings show a distinct icon (ℹ) and are counted separately in both human and JSON output. Reproducer: # Create a composition with a timed element missing class="clip" npx hyperframes lint # Was: "1 warning(s)" with ⚠ icon npx hyperframes lint --json # Was: severity: "info" but warningCount: 1 # Human and JSON output now agree
d4af810 to
9c93dff
Compare
3995974 to
d649ad3
Compare
miguel-heygen
left a comment
There was a problem hiding this comment.
Addressed: added pluralization for info count (info → infos). The check-hyperframe-static.ts findings loop already uses severity.toUpperCase() which correctly outputs "INFO" — no change needed there.
|
Consolidated into fix/lint-improvements. |

PR Stack
Summary
severity: "info"but human output said "1 warning(s)"Reproducer
Stack
6/8 — Depends on #126. Pairs with #126 (core linter change).
🤖 Generated with Claude Code