fix(media-use): create the output dir before ElevenLabs TTS writes [P1]#2032
Merged
Conversation
The ElevenLabs provider spawns a Python helper that writes straight to wavAbs
via a bare open(), which (unlike heygen/kokoro) never creates the parent dir —
so on a fresh project the save throws ENOENT and the line is silently dropped
as 'TTS failed - omitted'. mkdir -p the dir first, guarded so a mkdir failure
(EACCES/EROFS) returns { ok:false } like the rest of the branch rather than
throwing. (Migrated from #1960, whose skills/hyperframes-media path was retired
into skills/media-use; the bug moved with it.)
miguel-heygen
force-pushed
the
fix/media-use-elevenlabs-mkdir
branch
from
96bc759 to
f28540b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates #1960, whose
skills/hyperframes-mediapath was retired intoskills/media-use(via #… media-use v2). The bug moved with the file — I confirmed it still exists at the new path.Problem
The ElevenLabs provider in
skills/media-use/audio/scripts/lib/tts.mjsspawns a Python helper that writes straight towavAbsvia a bareopen(). Unlike heygen (transcodeToWav) and kokoro (thehyperframes ttsCLI), it never creates the parent dir, so on a fresh project (noassets/voice/yet) the save throws ENOENT and the line is silently dropped as "TTS failed - omitted".Fix
mkdir -pthe output dir before the spawn, guarded so a mkdir failure (EACCES/EROFS) returns{ ok:false }like the rest of the branch rather than throwing —synthesizeOne's contract is "never throws; failures return { ok:false }" (incorporates the try/catch parity note from @rames' review on #1960). Adds a regression test that drivessynthesizeOnewith a nested output path and asserts the dir is created. 6/6tts.test.mjspass.