fix(studio): retire legacy Style and Grade sections from flat inspector#2126
Open
vanceingalls wants to merge 1 commit into
Open
fix(studio): retire legacy Style and Grade sections from flat inspector#2126vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
The flat inspector rendered its new Style/Grade groups AND the legacy ColorGradingSection/StyleSections components a second time below them, visibly doubling every control. Remove the now-redundant legacy render call sites (and their now-unused imports) from PropertyPanelFlat.tsx; those components stay intact for the legacy (flag-off) PropertyPanel.
This was referenced Jul 10, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Seventh PR in the flat inspector stack (see #2120 for the foundation and full stack list). Removes the legacy
ColorGradingSection/StyleSectionsrender call sites fromPropertyPanelFlat.tsx— with the flag on, these were rendering a second time below their flat equivalents (Color grading, Radius, Stroke, Effects, Clip, Transparency, Fill all doubled).Stack: #2120 → #2121 → #2122 → #2123 → #2124 → #2125 → #2126 (this).
Why
This was flagged as an Important (non-blocking) finding in the final whole-branch review, then confirmed live during manual testing of #2125 — every Style/Grade control was visibly duplicated. Flat coverage was already confirmed complete for both groups, so the legacy twins were pure redundant duplication, not a fallback for missing functionality.
How
<ColorGradingSection>and<StyleSections hideFlex>blocks (and their now-dead imports) fromPropertyPanelFlat.tsxonly.propertyPanelColorGradingSection.tsx,propertyPanelStyleSections.tsx) are untouched — the non-flat legacyPropertyPanel.tsxstill uses them when the feature flag is off.useColorGradingControllernow runs exactly once per render instead of twice (the second invocation was inside the now-removed legacyColorGradingSectioninstance) — resolving another Important finding from the whole-branch review.Test plan
data-panel-sectionattribute) is absent with the flag on, scoped carefully to avoid a false failure against the flat Style group's own "Fill" row label (which is supposed to still render).oxlint/oxfmt/fallowclean.