chore(producer): resync stale committed puppeteer-core symlinks to lockfile version#2259
Conversation
9001fee to
27cd996
Compare
27cd996 to
c20e202
Compare
miga-heygen
left a comment
There was a problem hiding this comment.
#2259 — decouple statfsSync error handling from headroom gate
Verdict: LGTM 🟢
Incremental on top of #2256. Refactors the awkward re-throw pattern I noted in my #2256 review: the statfsSync try/catch was wrapping the headroom check too, requiring a err.message.includes("HDR pre-extraction needs") re-throw to let the headroom error propagate while swallowing the statfs error.
Now cleanly separated: statfsSync gets its own early-return try/catch (unsupported platform → skip the gate), and the headroom check + warning run outside any try/catch with a guaranteed freeBytes value. Same behavior, clearer control flow, no string-matching re-throw.
Review by Miga
miguel-heygen
left a comment
There was a problem hiding this comment.
Blockers on current head c20e202: (1) required regression check is failing and additional shards are pending; (2) the actual PR diff is not limited to the three Puppeteer symlink resyncs described in the body — it includes tracked packages/producer/node_modules contents and .DS_Store plus broad stacked changes, so the branch is not an atomic canonical fix. Rebase/split onto the intended base, remove generated artifacts and unrelated files, remove the AI-generated trailer from the public PR description, then rerun CI and request re-review.
miguel-heygen
left a comment
There was a problem hiding this comment.
Correction: my prior CHANGES_REQUESTED was based on the stale Graphite base file list. Comparing the head tree to current main shows identical tree SHA (3e0019c87f78) and no real delta; the refactor already landed via #2256. This PR has no code delta to review or stamp and should be closed as landed, or replaced with a fresh atomic symlink-only PR if that work is still intended.
0e69871 to
1dfb016
Compare

Status: superseded, empty diff
This PR originally resynced 3 stale
puppeteer-core/puppeteergit-tracked symlinks underpackages/producer/node_modules/. That fix is no longer needed: a separate PR (fix(producer): stop tracking node_modules symlinks, part of #2144) untracked those files entirely and merged intomainfirst — a cleaner fix than this one's resync.After restacking this branch onto current
main, the diff is now empty (0 files) — confirmed by GitHub refusing a base-branch update with "no new commits between base branch 'main' and head branch."Earlier review flagged a diff far broader than the stated 3-file resync (including
.DS_Storeand other tracked artifacts). That was drift from comparing against a stale pre-merge base — those files were removed by the same #2144 cleanup, independently of this PR, before this branch's comparison base caught up.No action needed from a reviewer; this PR can be closed once confirmed.