fix(audio): two things the envelopes needed to be heard at all - #3017
Open
vanceingalls wants to merge 2 commits into
Open
fix(audio): two things the envelopes needed to be heard at all#3017vanceingalls wants to merge 2 commits into
vanceingalls wants to merge 2 commits into
Conversation
vanceingalls
force-pushed
the
wa-5-automation-runtime-fixes
branch
from
August 4, 2026 20:24
7cbe4d0 to
9b2cd06
Compare
vanceingalls
force-pushed
the
wa-5-automation-runtime-fixes
branch
from
August 4, 2026 21:04
9b2cd06 to
b485d1d
Compare
vanceingalls
force-pushed
the
wa-5-automation-runtime-fixes
branch
from
August 4, 2026 21:19
b485d1d to
f092e79
Compare
Fallow audit reportFound 50 findings. Duplication (49)
Health (1)
Generated by fallow. |
The envelope was scheduled onto the transport's gain AudioParam, but the runtime rewrites that gain every tick from `data-volume` and the GSAP-seeked value — so it was erased within a frame. Volume automation was correct in the render and inaudible while previewing. The lane now feeds the per-tick path where the probed volume keyframes already sit, checked ahead of them so the two cannot fight, and the transport no longer schedules volume at all: one mechanism instead of two racing. The cost is honest — in preview the level steps per tick rather than per sample, exactly as the existing keyframe path does. The render still bakes it into the PCM sample-accurately, and FX parameters are still scheduled on their own AudioParams, since nothing rewrites those. Parsed lanes are cached by attribute text: the runtime asks once per tick per track, and parsing there would run the JSON parser 60 times a second for a value that only changes on an edit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A structural edit — an effect added, removed, bypassed, or a filter's pole count switched — was dropped. `buildFxChain`'s update reports false when the change is not merely new values, and the attribute observer ignored that, so the edit only took hold when the persisting write reloaded the composition. That reload restarted every playing track, which is what was heard as the audio chopping. The graph is now swapped in place: the old effects are detached, the new ones built and connected between the same source and gain, and any lanes re-scheduled onto the new nodes. The source node is never touched, so playback does not restart. A track with no chain is watched too, rather than wired through and forgotten, so adding its first effect is heard the same way. That means the function always returns a disposer instead of null for the empty case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vanceingalls
force-pushed
the
wa-5-automation-runtime-fixes
branch
from
August 4, 2026 21:43
f092e79 to
ea66fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3016. Both found by listening rather than by testing.
1. The volume lane was inaudible in preview. It was scheduled onto the
transport's gain AudioParam — but the runtime rewrites that gain every tick
from
data-volumeand the GSAP-seeked value, so the envelope was erased withina frame. Volume automation was correct in the render and silent in preview.
The lane now feeds the per-tick path where the probed volume keyframes already
sit, checked ahead of them so the two cannot fight, and the transport no longer
schedules volume at all: one mechanism instead of two racing.
The cost is stated plainly: in preview the level now steps per tick rather than
per sample, exactly as the existing keyframe path does. The render still bakes it
sample-accurately, and FX parameters are still scheduled on their own
AudioParams, since nothing rewrites those. Measured on a real duck —
0.550open,0.150ducked, clean ramps at both ends.2. Structural chain edits never applied to the running graph.
buildFxChain'supdatereportsfalsewhen a change is structural rather thannew values, and the attribute observer ignored that. So adding, removing or
bypassing an effect did nothing until the persisting write reloaded the
composition — and that reload restarted every playing track, which is what was
audible as the chop.
The graph is now swapped in place: old effects detached, new ones built and
connected between the same source and gain, lanes re-scheduled onto the new
nodes. The source node is never touched, so playback does not restart. A track
with no chain is watched too, so adding its first effect is heard the same way —
which means the attach function now always returns a disposer instead of
nullfor the empty case.
🤖 Generated with Claude Code