feat(cli): forward a reported catalog gap to the feedback channel - #3204
Merged
Conversation
A search miss already reached PostHog, where nobody was watching it. It now also goes to the same channel a CLI rating goes to, by the same best-effort POST, so a move the catalog is missing is read rather than queried. The forward is bounded and swallowed, and the ack prints before it, so a gap report can never fail or delay the command that sent it.
miga-heygen
approved these changes
Sep 4, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at exact head. Catalog search misses are now forwarded to the publish API endpoint as a best-effort POST, bounded by a 5s abort signal and wrapped in a catch so it never fails the command. Fields are capped to backend limits (500/500/50 chars). The ack prints before the forward fires so the reporter never waits on it. Three tests cover the happy path, truncation, and offline resilience.
— Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes feedback --search-missnow also POSTs the gap to the backend, which forwards it to the same Slack channel a CLI rating goes to. PostHog still records the event unchanged.Why
A reported gap is the one search report that is meant to leave the machine, and it names a move the catalog does not have yet. Until now it only became a PostHog event, which nobody watches, so a gap sat unread until someone thought to query for it. Ratings already reach a channel by exactly this path, and gaps are read by the same people.
How
submitCatalogSearchMissmirrorssubmitFeedback: same base URL, sameheygen_route: canaryheader, same 5s timeout, same field caps matched to the backend DTO, same swallowed failure. The ack prints before the forward, so a gap report cannot be delayed or failed by it.Needs the matching backend endpoint (
POST /v1/hyperframes/catalog_search_miss) to be deployed before anything reaches Slack. Until then the forward 404s and is swallowed, so this is safe to merge in either order.Test plan
bunx vitest run packages/cli/src/utils/submitFeedback.test.ts- 9 passed, covering the posted URL and body, field truncation, and that a failed forward never throws.bunx oxlintandbunx oxfmt --checkclean on the three changed files.packages/cli/src/commands/feedback.telemetryJoinKeys.test.tsfails to resolve@hyperframes/corein a fresh worktree, which reproduces identically on untouchedmainand is unrelated to this change.