fix(engine): retry capture screenshot timeouts - #3641
Merged
Conversation
miga-heygen
approved these changes
Sep 4, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Checked the new /Page\.captureScreenshot timed out/i pattern against the other classifier buckets (transient_browser, memory_exhaustion, verification) in captureFailure.ts — no overlap, so this can't misclassify into a different bucket. Small, additive, well-targeted: routes the exact Puppeteer CDP screenshot-timeout signature into the existing protocol_timeout recoverable path instead of falling through to fatal authoring. Tests cover both the classifier and the parallel-capture recovery check. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Screenshot protocol timeouts now enter the existing adaptive capture retry, allowing the renderer to reduce worker concurrency instead of hard-failing a valid long render.
Why
Puppeteer's
Page.captureScreenshot timed outsignature fell through toauthoring, so parallel capture treated a recoverable CDP timeout as fatal.How
Classify the exact screenshot method timeout as
protocol_timeout. Keep pressure-aware auto worker sizing as separate follow-up scope.Test plan
recoverable=trueThe full producer suite could not start in the task worktree because its existing dependency payload omitted generated and package
distartifacts; the exact producer recovery assertion is included for CI.