fix(runtime): wait for a finite dotlottie duration - #3651
Merged
Conversation
miga-heygen
approved these changes
Sep 4, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at exact fbffbf7cd.
Correct fix. When anim.duration is 0, undefined, NaN, or Infinity, the old code computed seek(NaN) or seek(Infinity), blanking the first frame. The guard (Number.isFinite(duration) && duration > 0) is the right predicate — it rejects all degenerate values and waits for the player to report a real duration before seeking.
Two tests cover both the degenerate cases (parameterized over 0, -1, NaN, Infinity, undefined) and the delayed-load scenario where duration transitions from 0 to a real value mid-session. The seek assertions ([50], [0], [100]) verify percentage clamping still works. Clean +29/-3.
— Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dotlottie v1 player reporting zero duration could receive
seek(NaN)at time zero and blank its first frame. Wait for a positive finite duration before seeking, then preserve the existing percentage clamping.Builds on #1577 by @calcarazgre646, refreshed against current main with invalid-duration and delayed-load coverage.
Validation: regression tests failed before the fix; all 171 adapter tests pass, runtime typecheck passes, and all pre-commit checks pass.