fix(cli): preserve batch GIF and frame-format options - #3666
Conversation
Port Dustin Persek’s fix and command regression from #1833 onto current main. Co-authored-by: Dustin Persek <dustin.persek@protonmail.com>
miguel-heygen
left a comment
There was a problem hiding this comment.
Reviewed 7cb72c8478efd8c7cffe0dfeda043700736dc0e4. No correctness findings.
packages/cli/src/commands/render/execute.ts:260 and :268 preserve the validated settings in the shared batch-row options, covering both local and Docker execution. packages/cli/src/commands/render.test.ts:1492 exercises the command handler and checks the resulting job settings. I traced both values through the producer request conversion to GIF encoding and source-video extraction.
Validation: static review of the complete diff and downstream consumers; no local runtime test rerun. Build, lint, typecheck, and CLI smoke passed; remaining CI was still running with no observed failures at review time. No prior reviews or comments.
Verdict: APPROVE
Reasoning: The two missing fields are forwarded at the correct shared boundary, with a focused regression covering the reported failure. Pending CI must complete before merge.
— Magi
Batch renders validate
--gif-loopand--video-frame-formatbut currently drop both before creating row jobs. Forwarding them makes a batch such as--format gif --gif-loop 3 --video-frame-format pngpreserve the same encoder and source-frame settings as a single render.Ports Dustin Persek’s fix and command regression from #1833 onto current main, with co-author credit. The original branch contains unsigned commits, so this successor preserves the contribution in a signed commit.
Validation: the real command-handler regression failed before the fix (both job settings were undefined); all 87 render/batch tests pass after it. CLI typecheck, lint, formatting and commit hooks pass.