refactor(studio): improve player store with zoom and element updates

[miguel-heygen]

Summary

• Add zoom state (zoomMode, pixelsPerSecond) to player store
• Add timeline element updates (setElements, clearElements)
• Remove unused/duplicate exports from player barrel file

🤖 Generated with Claude Code

[miguel-heygen]

• refactor(studio): wire vite.config.ts to shared studio API module #115
• refactor(core): extract shared studio API module #113
• fix(core): strip template wrapper before linting composition files #111
• fix(cli): align render output naming and add WebM support to studioServer #109
• feat(studio): render queue, layout restructure, home page, hover preview #95
• feat(studio): add left sidebar with Compositions and Assets tabs #94
• feat(studio): add Edit Range toolbar with Copy to Agent #65
• refactor(studio): update layout, config, and remove agent activity tracking #64
• refactor(studio): improve Timeline, PlayerControls, and player hook #63
• feat(studio): add TimelineClip and thumbnail components #62
• refactor(studio): improve player store with zoom and element updates #61 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[vanceingalls]

Review: PR #61 — Player Store Refactor

Clean removal of agent tracking state, good zoom/edit-range additions, solid tests.

Issues

[Important] setCurrentTime does not guard against NaN/Infinity. setDuration has if (!Number.isFinite(duration)) return but setCurrentTime does not. If an adapter returns NaN or Infinity, it flows straight into the store.

[Suggestion] updateElement accepts Partial<Pick<...>> but does not validate. Passing { start: NaN } or { duration: -1 } silently corrupts the element. Consider clamping like setDuration does.

What's well done

• liveTime pub-sub pattern avoids React re-renders during playback — exactly right
• setPixelsPerSecond clamps to minimum of 10
• setDuration guards against non-finite values
• Test coverage is thorough (265 lines) — covers all actions, edge cases, reset semantics
• reset() intentionally preserves zoom/playbackRate with explicit test documentation

[miguel-heygen]

Thanks for the review Vance!

Addressed:

• ✅ setCurrentTime now guards against NaN/Infinity: set({ currentTime: Number.isFinite(time) ? time : 0 })

Not addressed (tracked for follow-up):

• updateElement validation (clamping negative duration, NaN start) — will add in a follow-up PR with more comprehensive store validation

[miguel-heygen]

Merge activity

• Mar 28, 7:59 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Mar 28, 7:59 AM UTC: @miguel-heygen merged this pull request with Graphite.