refactor(studio): update layout, config, and remove agent activity tracking#64
refactor(studio): update layout, config, and remove agent activity tracking#64miguel-heygen merged 1 commit intomainfrom
Conversation
3814bd6 to
b31f9b4
Compare
239c259 to
3f73516
Compare
b31f9b4 to
47085f8
Compare
3f73516 to
fa1456d
Compare
42ea330 to
5736c89
Compare
38e3bb8 to
44f580d
Compare
5736c89 to
065bdb9
Compare
44f580d to
14e3a4d
Compare
065bdb9 to
7322b6b
Compare
14e3a4d to
3a0d4bd
Compare
cb136dd to
89b1ccc
Compare
fe108bc to
f92d4ad
Compare
Review: PR #64 — Layout, Config, Agent Activity RemovalGood cleanup. htmlEditor.ts XSS issues from PR #56 resolved by removing splitElement/deleteElement entirely. Issues[Important] `NLELayout` performs side effects during render. The project-switch detection (`prevProjectIdRef`) and `activeCompositionPath` handling execute state updates during the render phase. These should be in `useEffect` hooks for concurrent-mode safety. [Important] PUT endpoint still has no body size limit (carried from PR #56 review). Dev-only, but worth adding. [Important] Puppeteer browser singleton still never closes on server shutdown. Add: [Important] Render job TTL still parses timestamps from key strings. `parseInt(key.split("-").pop())` breaks if project ID contains hyphens. Store `createdAt` in the job object. **[Suggestion] `htmlEditor.ts` `findElementBlock` only matches double-quoted `id` attributes. Single-quoted `id='foo'` returns null. **[Suggestion] `htmlEditor.ts` still has no unit tests — functions are pure string→string, ideal for testing. What's well done
|
f92d4ad to
c041eb5
Compare
3a0d4bd to
819ed22
Compare
c041eb5 to
f006008
Compare
|
Thanks for the thorough review! Addressed:
Not addressed (tracked for follow-up):
|
3b33d10 to
f0933a1
Compare
f0933a1 to
304c7c7
Compare
ed59f2c to
accaf1d
Compare
Merge activity
|
304c7c7 to
44b0ac0
Compare
accaf1d to
35185cb
Compare
44b0ac0 to
a5f1a98
Compare
59a4e18 to
e4ca7c4
Compare
51cd554 to
e6c4d1f
Compare
e4ca7c4 to
e8662d9
Compare
e6c4d1f to
a75cc6a
Compare
a4b8c6f to
d1ad101
Compare
a75cc6a to
b9274af
Compare
b9274af to
0769678
Compare
d1ad101 to
b088b34
Compare
- NLELayout: add toolbar slot, composition breadcrumb, improved resizing - App: update toolbar wiring, remove split/delete, add edit modal - Remove AgentActivityTrack (unused) - Update vite config with improved dev server and build settings - Update package.json dependencies - Simplify htmlEditor.ts (keep parseStyleString, mergeStyleIntoTag, findElementBlock) - Update exports in index.ts
b088b34 to
fa4b1e4
Compare

Summary
vite buildfrom hanging in CI🤖 Generated with Claude Code