fix: centralize chat markdown rendering - #181
Conversation
|
Thanks for cleaning this up @Rohithmatham12 👑 Centralizing the markdown rendering is a good idea and should reduce sanitizer drift across the chat surfaces. Could you also fix one remaining security issue in the portal chat HTML export path?
This looks pre-existing rather than introduced by this PR, but since this PR already touches the export plaintext behavior, it would be great to handle it here too. Please escape script-breaking sequences before embedding JSON into the inline script, for example by replacing |
8f27fbf to
778a9ac
Compare
|
Thanks for catching that. I updated the export path to escape JSON before embedding it in the inline script, covering |
|
Thank you 💯 |
Summary
styleattribute from the shared user-markdown allowlistTesting
bun run lint:checkbun run typecheckbun run buildgit diff --checkuv run ruff check .