Hide JSON tree/plain toggle buttons in console output when node is running - #393
Merged
Merged
Conversation
…nning The change is complete. Here's a summary: **What was done:** Added `result.status !== 'running'` condition to the Tree/Plain toggle button visibility in `DebugPanel.vue:2815`. When a node is currently executing (running), the JSON tree/plain toggle buttons are now hidden since there's no final data to display yet. **What was the issue:** The Tree/Plain toggle buttons were appearing in the console output area for nodes that were still running, despite having no completed output to display. **Existing rules preserved:** Error nodes continue to hide buttons (`!result.error`), and success/pending nodes with valid JSON continue to show buttons. **Screenshot:** `frontend/.e2e-artifacts/running-node-toggle-hidden.png` ## Summary - **Changed file:** `frontend/src/components/Panels/DebugPanel.vue` (line 2815) - **Change:** Added `result.status !== 'running'` to the existing `v-if` condition that controls visibility of the Tree/Plain toggle buttons in the DebugPanel console output - **Behavior:** When a node's execution status is `'running'`, the JSON tree/plain toggle buttons are hidden. They remain visible for completed (success), pending, and other non-error non-running states. Error node hiding behavior is preserved via the existing `!result.error` check. - **Screenshot:** `frontend/.e2e-artifacts/running-node-toggle-hidden.png`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is complete. Here's a summary:
What was done: Added
result.status !== 'running'condition to the Tree/Plain toggle button visibility inDebugPanel.vue:2815. When a node is currently executing (running), the JSON tree/plain toggle buttons are now hidden since there's no final data to display yet.What was the issue: The Tree/Plain toggle buttons were appearing in the console output area for nodes that were still running, despite having no completed output to display.
Existing rules preserved: Error nodes continue to hide buttons (
!result.error), and success/pending nodes with valid JSON continue to show buttons.Screenshot:
frontend/.e2e-artifacts/running-node-toggle-hidden.pngSummary
frontend/src/components/Panels/DebugPanel.vue(line 2815)result.status !== 'running'to the existingv-ifcondition that controls visibility of the Tree/Plain toggle buttons in the DebugPanel console output'running', the JSON tree/plain toggle buttons are hidden. They remain visible for completed (success), pending, and other non-error non-running states. Error node hiding behavior is preserved via the existing!result.errorcheck.frontend/.e2e-artifacts/running-node-toggle-hidden.pngScreenshots