impl/cancel-bus - #446
Merged
Merged
Conversation
- Introduced `execution_cancel_listener` to manage execution cancellation events. - Updated `ActiveExecutionRegistry` to track command attempts and drop permanently failing commands after a set number of retries. - Modified `request_persisted_execution_cancel` to ensure cancellation broadcasts occur even if the database update fails. - Added tests to verify that cancelled executions are excluded from processing and that command attempts reset upon success. This improves the resilience of the execution cancellation process and prevents blocking due to persistent failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: enhance execution cancellation logic and add retry mechanism
execution_cancel_listenerto manage execution cancellation events.ActiveExecutionRegistryto track command attempts and drop permanently failing commands after a set number of retries.request_persisted_execution_cancelto ensure cancellation broadcasts occur even if the database update fails.This improves the resilience of the execution cancellation process and prevents blocking due to persistent failures.