Skip to content

Fix deployment script to re-enable hacklang.org publishing#38

Merged
tlil merged 4 commits intohhvm:mainfrom
tlil:fix-deployment-script
Oct 30, 2025
Merged

Fix deployment script to re-enable hacklang.org publishing#38
tlil merged 4 commits intohhvm:mainfrom
tlil:fix-deployment-script

Conversation

@tlil
Copy link
Copy Markdown
Contributor

@tlil tlil commented Oct 30, 2025

The current GitHub Action uses the old way of publishing the Docusaurus static website to GitHub Pages (hosted under CNAME hacklang.org), needing an SSH key (from Secrets) in order to push to site, which has now expired.

This PR fixes the publishing flow by:

  • Updating the publishing job to use the latest version of actions/checkout and setup-node
  • Upgrading the Node dependency from v12.x to v24
  • Moving the Docusaurus source code from website/ to root
  • Adding a separate deploy step, using actions/deploy-pages to publish the static build

Minor updates also covered in the PR:

Testing

image

@meta-cla meta-cla Bot added the CLA Signed label Oct 30, 2025
Copy link
Copy Markdown
Contributor

@Wilfred Wilfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I trust you :)

@tlil tlil merged commit c745cc6 into hhvm:main Oct 30, 2025
4 checks passed
@tlil tlil deleted the fix-deployment-script branch October 30, 2025 12:18
@tlil

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants