fix: skip symlinked source skills instead of refusing the run - #17
Merged
Conversation
The symlink guard was added so a symlinked target directory could not route rm -rf at the canonical skills. Applied to source skills it was too blunt: one symbolic link aborted the whole run, and plugin-installed skills are routinely links into a shared skills directory, so the command was unusable on any machine with one. Running it for real against 53 skills, 10 of them plugin links, propagated nothing at all. A symlinked source skill is still never copied, since it can resolve anywhere. It is now skipped by name, counted in the summary, and the remaining skills propagate. Eligibility is decided once so the per-target loop cannot disagree with the check. Adds docs/walkthrough.md, every command with real output including the refusals and safety behaviours that are easy to miss. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by demonstrating the CLI against a real machine rather than a fixture.
agent skills syncaborted entirely when any source skill was a symbolic link. On a machine with 53 skills, 10 of them plugin-installed links into the shared~/.agents/skillsdirectory, that meant zero skills ever propagated. The guard was right to distrust symlinks, since one can resolve anywhere, but wrong to fail the whole operation over it.Now a symlinked source skill is skipped by name, counted in the summary, and everything else syncs. Re-running against the same machine propagated 42 skills to 9 agents with the 10 links reported. Eligibility is computed once so the per-target copy loop cannot disagree with the preflight check.
Tests updated: the old fixture pinned the refuse-everything behaviour, so it now asserts the opposite, that a symlinked skill is skipped while a plain skill alongside it still reaches the target.
Also adds
docs/walkthrough.md, every command with real output. It documents the refusals people otherwise mistake for bugs: unowned files never rewritten, Kiro taking stdio servers only, Codex dropping unsupported headers loudly, and Zed's first-match shadowing.🤖 Generated with Claude Code