NoORM IntelliJ styles update #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change anything to the style, this is the same style but as written with a newer version of IntelliJ. The purpose of this commit is to make the diff of the next commits understandable.
This does not change anything to the style, this is the same style but as written with a newer version of IntelliJ. The purpose of this commit is to make the diff with the OGM style understandable.
Since we are also using it in Search.
…ters in NoORM projects
I.e. do this:
foo.someMethod().someOtherMethod().yetAnotherMethod( firstParam,
secondParam, thirdParam );
Or this:
foo.someMethod().someOtherMethod().yetAnotherMethod(
firstParam, secondParam, thirdParam
);
But certainly not this:
foo.someMethod().someOtherMethod().yetAnotherMethod( firstParam,
secondParam,
thirdParam );
Nor this:
foo.someMethod().someOtherMethod().yetAnotherMethod(
firstParam,
secondParam,
thirdParam
);
The main reason being to avoid wasting space, but also to avoid IntelliJ
inserting spaces after tabs in the indent to be exactly aligned.
This is a rule that we enforce with checkstyle, so there's no way around it. We may as well take it into account in the IntelliJ styles.
Apparently it's a rule we want to enforce, see https://hibernate.atlassian.net/browse/HSEARCH-2430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed commit by commit: the first two commits introduce massive changes in the settings file format (IntelliJ's fault, not mine) but no actual style changes.