Skip to content

HV-381 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
27 commits merged into from
Feb 13, 2011
Merged

HV-381 #25

27 commits merged into from
Feb 13, 2011

Conversation

@hferentschik
Copy link
Contributor

@hferentschik hferentschik commented Feb 12, 2011

  • Switching back to failFast(boolean)
  • Validator immutable
  • HibernateValidatorContext overrides methods in ValidatorContext

kevinpollet and others added 27 commits February 11, 2011 11:56
@kevinpollet @hferentschik
HV-381: Add fail fast switch to HibernateValidatorConfiguration.
8fa4913
@kevinpollet @hferentschik
HV-381: Provide fail fast configuration on validator context.
4ea9f12
@kevinpollet @hferentschik
HV-381: Add fail fast support in the core.
373c46c
@kevinpollet @hferentschik
HV-381: Add fail fast unit tests.
bcda7e1
@kevinpollet @hferentschik
HV-381: Support fail fast as a validator factory property.
e368d41
@kevinpollet @hferentschik
HV-381: Add some javadoc and modify test method name.
b209491
@kevinpollet @hferentschik
HV-381: Add Emmanuel perf test (make sure to set log to ERROR before …
643c98a 
…running)
@kevinpollet @hferentschik
HV-381: Improve TestUtil.
2c28829
@kevinpollet @hferentschik
HV-381: Add fail fast test for method validation.
895905e
@hferentschik
HV-381 Commenting out some tests, because they don't compile for now
8dc6a93
@hferentschik
HV-381Let HibernateValidatorContext extends ValidatorContext
d1208ae
@hferentschik
HV-381 Formatting
bf4b0eb
@hferentschik
HV-381 Let HibernateValidatorFactory extends ValidatorFactory
bbb2e82
@hferentschik
HV-381 Get rid of usingHibernateContext()
5a0ceba
@hferentschik
HV-381 Re-enabling method validation fail fast tests and adding a logger
6261029
@hferentschik
HV-381 Import cleanup
bd08b53
@hferentschik
HV-94 Javadoc
c27d93f
@hferentschik
HV-94 Deciding for the 'HibernateValidatorConfiguration failFast()' a…
6681dc6 
…pproach
@hferentschik
HV-94 Updating tests and adding new test for inconsistent configurati…
40bb0c9 
…on via properties and programmatic api
@hferentschik
HV-381 Adding documentation for fail fast
08801de
@hferentschik
HV-381 Adding failFast(boolean) to ValidatorImpl and adding a test
03be03c
@hferentschik
HV-381 Adding docs for unwrapping of ValidatorImpl
519dbf7
@hferentschik
HV-381 No fail fast on ValidatorImpl. Validator should be considered …
ef85b42 
…immutable
@hferentschik
HV-381 Updating docs - it is failFast(boolean) and not fail fast on V…
5d16eca 
…alidator
@hferentschik
HV-381 Re-introduced failFast(boolean) and overriding methods from Va…
829c4fa 
…lidatorContext to allow method chaining
@hferentschik
HV-381 Switching back to failFast(boolean)
e38e822
@hferentschik
HV-381 Import cleanup
5f459a5
@gunnarmorling
Copy link
Member

gunnarmorling commented Feb 12, 2011

Looks good to me now. I'll just fix some typos, unify ValidatorContextImpl and HibernateValidatorContextImpl (one impl for both context IFs should do the trick) and bring this in.

gunnarmorling
gunnarmorling reviewed Feb 12, 2011
View reviewed changes
hibernate-validator/src/main/java/org/hibernate/validator/engine/ValidatorImpl.java
Copy link
Member

@gunnarmorling gunnarmorling Feb 12, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why there is this method and ValidationContext#shouldFailFast(). Maybe only the latter would suffice?

@gunnarmorling
Copy link
Member

gunnarmorling commented Feb 13, 2011

To get things going I'm applying the request now. I'll create a new JIRA issue for my last remark (ValidatorImpl#shouldFailFast()vs. ValidationContext#shouldFailFast()). If we need both methods this can be closed without further action.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hferentschik @gunnarmorling @kevinpollet