Skip to content

Updated content to fit original repo#14

Merged
hienvd merged 6 commits into
hienvd:masterfrom
timnqp:master
Mar 1, 2017
Merged

Updated content to fit original repo#14
hienvd merged 6 commits into
hienvd:masterfrom
timnqp:master

Conversation

@timnqp

@timnqp timnqp commented Feb 27, 2017

Copy link
Copy Markdown
Contributor
  1. Updated table of content
  2. Swapped Classes & SOLID
  3. Updated example functions in Objects and Data Structures

@hienvd

hienvd commented Feb 27, 2017

Copy link
Copy Markdown
Owner

@quangphuc789
The anchor link to 6.SOLID in table of content seems doesn't work when I click on it.
Please take a look.

@hienvd
hienvd requested a review from tiennv91 February 27, 2017 17:06
@timnqp

timnqp commented Feb 28, 2017

Copy link
Copy Markdown
Contributor Author

@hienvd @tiennv91 I have made the changes to add anchor link to 6. SOLID
I have made another pull request. Can you review?

#15

@hienvd

hienvd commented Feb 28, 2017

Copy link
Copy Markdown
Owner

It works now, thanks @quangphuc789
Btw, no need to create another PR.

@tiennv91: Looks good to me, waiting for your review :)

@timnqp

timnqp commented Feb 28, 2017

Copy link
Copy Markdown
Contributor Author

@hienvd @tiennv91 I have made a new commit, which updated the Chinese language versions. Cheers :)

@hienvd
hienvd merged commit 44dff03 into hienvd:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants