devops: stop stray PR comments from cancelling an in-flight Gemini review - #139
Merged
Conversation
…view Every issue_comment on a PR enters the per-PR concurrency group before the job-level if filters it out, so unconditional cancel-in-progress let ANY comment (observed: codecov's coverage comment on #137) kill a running review, with the superseding run then skipping itself. Make cancellation conditional: only a pull_request trigger or an explicit /gemini-review command supersedes; other comments queue and skip.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 95 95
Lines 16406 16406
=======================================
Hits 13384 13384
Misses 3022 3022
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/gemini-review |
1 similar comment
Collaborator
Author
|
/gemini-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a footgun in the
gemini-review.ymlworkflow added in #136, observed live on #137.Symptom: PR #137's review run was cancelled 1m53s in. The canceller was codecov's coverage comment: every
issue_commenton a PR enters the per-PR concurrency group before the job-leveliffilters it out, socancel-in-progress: truelet any comment (codecov, a human reply, even the review bot's own posted review) kill an in-flight review — and the superseding run then skips itself because it isn't a/gemini-reviewcommand. Net effect: reviews silently die whenever anything comments while they run.Fix: make
cancel-in-progressconditional — only apull_requesttrigger or an explicit/gemini-reviewcommand supersedes an in-flight run. Non-command comments queue for a moment behind the running review, then skip on the jobif, harmlessly.github.event.comment.body || ''keeps the expression null-safe onpull_requestevents (nocommentin the payload).🤖 Generated with Claude Code