Add TransactionSigner Interface to makeTransaction functions #443
+538
−321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This worked fine with the operations integrations tests Trying a mainnet transaction now. |
larrysalibra
approved these changes
May 4, 2018
There was a problem hiding this comment.
I also tested this by linking this to the develop branch of the browser and sending a mainnet bitcoin transaction to transfer funds out of my browser wallet to another address. The transaction was successfully signed. Thanks @kantai !
|
Awesome, thanks @larrysalibra -- will add an entry to the changelog.md and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface definition and support for using it to the makeTransaction functions.
Background on the interface is here:
https://forum.blockstack.org/t/proposal-transaction-signer-interface-for-blockstack-js/5043/4
This does not add any new functionality to
blockstack.js, but someone using the library would be able to define their own transaction signer class to enable support for things like multi-sig addresses, segwit, or hardware wallets.This is tested via the existing unit tests and integration testing (
npm run operations-tests)To test on mainnet, you can link this branch into blockstack-browser and perform a registration.