Skip to content

fix: support FTs with missing metadata but correct token data #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaelcr merged 2 commits into from
Apr 3, 2023
Merged

fix: support FTs with missing metadata but correct token data #150

rafaelcr merged 2 commits into from
Apr 3, 2023

Conversation

@rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Apr 3, 2023

Fixes #149

@rafaelcr rafaelcr requested a review from zone117x April 3, 2023 01:16
@rafaelcr rafaelcr temporarily deployed to Preview April 3, 2023 01:17 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

Vercel deployment URL: https://token-metadata-dkj1t4btu-blockstack.vercel.app 🚀

@rafaelcr rafaelcr linked an issue Apr 3, 2023 that may be closed by this pull request
fall back to FT contract decimal and name values if metadata fails #149
Closed
@rafaelcr rafaelcr temporarily deployed to Preview April 3, 2023 01:28 — with GitHub Actions Inactive
zone117x
zone117x approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@rafaelcr rafaelcr merged commit 0a5558e into develop Apr 3, 2023
@rafaelcr rafaelcr deleted the fix/ft-contracts branch April 3, 2023 14:17
blockstack-devops pushed a commit that referenced this pull request Apr 3, 2023
@semantic-release-bot
chore(release): 0.3.0 [skip ci]
04b62db 
## [0.3.0](v0.2.1...v0.3.0) (2023-04-03)

### Features

* add `invalid` job status to mark invalid contracts or tokens ([#148](#148)) ([5d6ef41](5d6ef41))

### Bug Fixes

* support FTs with missing metadata but correct token data ([#150](#150)) ([0a5558e](0a5558e))
@blockstack-devops
Copy link
Contributor

blockstack-devops commented Apr 3, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zone117x zone117x zone117x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fall back to FT contract decimal and name values if metadata fails

4 participants

@rafaelcr @blockstack-devops @zone117x