Skip to content

feat: add invalid job status to mark invalid contracts or tokens #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2023
Merged

feat: add invalid job status to mark invalid contracts or tokens #148

merged 6 commits into from
Mar 28, 2023

Conversation

@rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Mar 27, 2023 •
edited
Loading

  • Add invalid job status
  • Mark invalid when there is a user error (wrong metadata format, not SIP-016, unreachable, bad clarity types, etc.)
  • Respond with an informative error if invalid contracts/tokens are requested

Fixes #128
Fixes #118
Fixes #138

@rafaelcr rafaelcr temporarily deployed to Preview March 27, 2023 20:05 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 27, 2023 •
edited
Loading

Vercel deployment URL: https://token-metadata-9mnvtbqr6-blockstack.vercel.app 🚀

@rafaelcr rafaelcr temporarily deployed to Preview March 27, 2023 20:16 — with GitHub Actions Inactive
This was linked to issues Mar 27, 2023
Tokens stuck in "metadata fetch in progress" #128
Closed
add new invalid job status #118
Closed
return "smart contract not found" if contract is missing #138
Closed
@rafaelcr rafaelcr requested a review from zone117x March 27, 2023 20:16
zone117x
zone117x approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rafaelcr rafaelcr merged commit 5d6ef41 into develop Mar 28, 2023
@rafaelcr rafaelcr deleted the fix/errors branch March 28, 2023 16:32
blockstack-devops pushed a commit that referenced this pull request Apr 3, 2023
@semantic-release-bot
chore(release): 0.3.0 [skip ci]
04b62db 
## [0.3.0](v0.2.1...v0.3.0) (2023-04-03)

### Features

* add `invalid` job status to mark invalid contracts or tokens ([#148](#148)) ([5d6ef41](5d6ef41))

### Bug Fixes

* support FTs with missing metadata but correct token data ([#150](#150)) ([0a5558e](0a5558e))
@blockstack-devops
Copy link
Contributor

blockstack-devops commented Apr 3, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zone117x zone117x zone117x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

return "smart contract not found" if contract is missing Tokens stuck in "metadata fetch in progress" add new invalid job status

4 participants

@rafaelcr @blockstack-devops @zone117x