Add newer Intel CPUs from openhardwaremonitor-0.9.5#1004
Closed
Dwedit wants to merge 1 commit intohirschmann:masterfrom
Closed
Add newer Intel CPUs from openhardwaremonitor-0.9.5#1004Dwedit wants to merge 1 commit intohirschmann:masterfrom
Dwedit wants to merge 1 commit intohirschmann:masterfrom
Conversation
Dwedit
changed the title
Author
|
This appears to cause abrupt shutdowns when AC is not plugged in, will investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix issue #1003 and add support for newer CPUs released after 2017.
The service was throwing an exception on startup, and this led to the program not working, and creating over 4000 startup failures in the event log.
The cause was that it was unable to find the CPU sensors. Upgrading the Intel CPU code to a newer version of openhardwaremonitor-0.9.5 seems to have fixed the problem.
Note that this is a hack-job of selectively copy-pasting lines from openhardwaremonitor-0.9.5 in a way to not break compatibility, the code no longer matches any released version. Ideally, we'd want to upgrade all the code to openhardwaremonitor-0.9.5, but some code that uses it currently doesn't work with that version.
Perhaps we'd also like to have the service no longer set to endlessly restart itself on every failure.