Skip to content

Add Asus Vivobook TP301UA#220

Closed
NavidDanesh wants to merge 5 commits intohirschmann:masterfrom
NavidDanesh:patch-2
Closed

Add Asus Vivobook TP301UA#220
NavidDanesh wants to merge 5 commits intohirschmann:masterfrom
NavidDanesh:patch-2

Conversation

@NavidDanesh
Copy link
Copy Markdown

@NavidDanesh NavidDanesh commented Apr 18, 2017

Please add this config for Asus Vivobook TP301UA

@NavidDanesh NavidDanesh deleted the patch-2 branch April 19, 2017 16:26
@NavidDanesh NavidDanesh changed the title Create ASUS VivoBook TP301UA ASUS VivoBook TP301UA Apr 21, 2017
@NavidDanesh NavidDanesh restored the patch-2 branch April 21, 2017 16:49
@NavidDanesh NavidDanesh deleted the patch-2 branch April 21, 2017 16:49
@NavidDanesh NavidDanesh restored the patch-2 branch April 21, 2017 16:53
@NavidDanesh NavidDanesh reopened this Apr 21, 2017
@hirschmann
Copy link
Copy Markdown
Owner

Thanks for the config 👍

The config itself looks good, but the filename has some flaws:

  1. The config should have a .xml file extension
  2. Avoid screeming caps in the filename

Please change the filename to Asus VivoBook TP301UA.xml

@NavidDanesh NavidDanesh changed the title ASUS VivoBook TP301UA Asus Vivobook TP301UA Apr 23, 2017
@NavidDanesh NavidDanesh changed the title Asus Vivobook TP301UA Add Asus Vivobook TP301UA Apr 23, 2017
@NavidDanesh
Copy link
Copy Markdown
Author

NavidDanesh commented Apr 23, 2017

Sorry
I can't attach the xml to my post!
https://github.com/NavidDanesh/nbfc/blob/master/Configs/Asus%20Vivobook%20TP301UA.xml

@hirschmann
Copy link
Copy Markdown
Owner

I've added the config myself, see 2998a2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants