Add ascii method#22
Merged
Merged
Conversation
added 7 commits
March 24, 2017 23:20
Prints an ascii histogram, similar to ascii method in histogrammar scala library.
I wanted to optimise the program by combining filling of values array and filling of ranges array, but I forgot that I had changed my implementation to not iterate over certain indeces for ranges array.
Member
|
Actually, I was too quick to accept that pull request. See #23, which corrects several points. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented an ascii method similar to that in Scala version of histogrammar. Ascii prints out to console a histogram of Bin.
In my implementation I created two helper methods and by doing so attempted to make the implementation more modular. Please let me know if this is not the design pattern you would like me to use.