Skip to content

Update currency API URL to latest working version - #231

Open
i-m-soumya wants to merge 1 commit into
hiteshchoudhary:mainfrom
i-m-soumya:main
Open

Update currency API URL to latest working version#231
i-m-soumya wants to merge 1 commit into
hiteshchoudhary:mainfrom
i-m-soumya:main

Conversation

@i-m-soumya

@i-m-soumya i-m-soumya commented Dec 24, 2024

Copy link
Copy Markdown

Overview
This PR updates the currency API URL to the latest working version. The previous URL was outdated and no longer functional, causing issues retrieving currency data.

Changes Made
Replaced the old URL:
https://cdn.jsdelivr.net/gh/fawazahmed0/currency-api@1/latest/currencies/${currency}.json
with the new URL:
https://cdn.jsdelivr.net/npm/@fawazahmed0/currency-api@latest/v1/currencies/${currency}.json.
Reason for the Change
The previous endpoint is no longer available, leading to broken application functionality. The new URL aligns with the updated API structure.

Testing
Verified the new URL fetches data successfully.
Ensured the change impacts no other parts of the application.
Impact
This change restores the ability to fetch currency data and ensures the application functions as expected.

@hiteshchoudhary Please review and let me know if any additional adjustments are required.

@Arihant2312

Copy link
Copy Markdown

api request not woking for new link also

@Bishwo-sh

Bishwo-sh commented Dec 31, 2024

Copy link
Copy Markdown

https://cdn.jsdelivr.net/npm/@fawazahmed0/currency-api@latest/v1/currencies/usd.json
did you change currency to smth like usd

api request not woking for new link also

@i-m-soumya

Copy link
Copy Markdown
Author

@Bishwo-sh Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants